Closed rgm closed 3 years ago
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
Thanks for the patch. Can you split this into two commits?
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
Thanks for the commits. Could you cut down the second commit message to just:
Add woff2 font file mime-type
See https://tools.ietf.org/html/rfc8081#section-4.4.6
The rest of the commit message doesn't add any more information.
@weavejester need anything more here?
I'm not notified about new commits on a PR unless a review is requested or a comment is made. The updates look fine, though.
The mime types for WOFF fonts have been standardized and extended in RFC 8081. Per RFC 8081 § 4.4.5, the old
application/font-woff
should be replaced withfont/woff
.Ring didn't previously have a definition for WOFF2. This commit adds it per RFC 8081 § 4.4.6. Including it allows Ring to properly auto-assign content type for files with a .woff2 extension on disk. These are currently going out as a blank content type by default.