Closed mcorbin closed 3 years ago
Create a new lein project with ring as dependency
Have you created your own Ring deps based off master
?
Have you created your own Ring deps based off master?
Thanks, I know what is the issue now.
I thought 1.8.2
was including my commit (because it was merged before the tag) but it seems 1.8.2
only contains commit 7a3768d6f943bc7507e28bd2b0760f09ae7600f5
, which is Update Jetty version to 9.4.31 (fixes #411)
. If I use lein install
on master it indeed works.
Is it expected to only have one commit between 1.8.1 and 1.8.2 ?
1.8.2 is a patch release, which means it only contains fixes, not any new features. Ring 1.9.0 will contain your patch, but it's not released yet. There's probably enough changes now in the pipeline for a 1.9 release, so I'll see about getting it released this month.
Thank you for your answer, I'm closing this issue.
Hi, I'm also hoping to make use of this ssl-context feature--do you have any sense of when Ring 1.9.0 might be released?
Hi, I'm also hoping to make use of this ssl-context feature--do you have any sense of when Ring 1.9.0 might be released?
Ring 1.9.0 has now been released.
Hello,
In https://github.com/ring-clojure/ring/pull/412, I added support for the
:ssl-context
option to the ring jetty adapter. Now, I'm trying to use this option again and I cannot make TLS work.How to reproduce
Then run
(def s (jetty/run-jetty hello-world (config))
.This is what happens when I try to curl my endpoint:
I see on the JVM side (with
:jvm-opts ["-Djavax.net.debug=ssl"]
in my project.clj):it works on the ring repository
The exact same code works on the ring project. I've started a REPL in the
ring-jetty-adapter
project, copied the previous code in a new file, started jetty, and now curl works:I use insecure because the certs are expired, but at least it works.
Also, I've added in the PR I did to add the option a lot of tests and they are all passing.
What I tried
--tlsv1.2 --tls-max 1.2
to my curl request to the faulty server, I get in the logs:The issue should be somehow related to the Jetty TLS configuration (version, cipher), but it works on the ring-jetty-adapter project and I cannot understand why. Maybe I'm doing something wrong (it's probably the case) but I cannot find differences between my code and the jetty project code.