Clarify what request-header-size and response-header-size mean

ring-clojure / ring

Clojure HTTP server abstraction

MIT License

3.75k stars 519 forks source link

Clarify what request-header-size and response-header-size mean #440

Open mikekap opened 3 years ago

mikekap commented 3 years ago

Jetty's config options are for the PROTOCOL header, not a single Field: Value pair. So these options control the sum of all headers and status lines.

atomist[bot] commented 3 years ago

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

The commit message subject is over 50 characters.
The commit message body has a line over 72 characters.

weavejester commented 3 years ago

Do you have a source for that? I ask not to doubt, but so we have a record of why changes were made.

mikekap commented 3 years ago

Unfortunately Jetty hasn't quite updated the docs, but this was the only source that I could find: https://github.com/eclipse/jetty.project/issues/6204#issuecomment-823907944 . The other way is to read through the code and notice that the length is used to allocate a buffer that includes the status line and all the headers.

weavejester commented 3 years ago

Thanks. From my reading of the link you provided, the sizes don't include the request/response line.