ring-clojure / ring

Clojure HTTP server abstraction
MIT License
3.75k stars 519 forks source link

Allow user to supply their own thread pool for Jetty #444

Closed Whoops closed 2 years ago

Whoops commented 3 years ago

Hello!

In order to better understand our services, we're looking to metrics our thread pools. Specifically, we're looking to use metric'sInstrumentedQueuedThreadPool in place of Jetty's default QueuedThreadPool. Unfortunately this adapter doesn't allow for the possibility of using an alternate ThreadPool implementation. I propose adding an option to let the user provide their own pool instead of having the adapter create one.

atomist[bot] commented 3 years ago

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

Whoops commented 3 years ago

Thanks! I've addressed the above comments.

weavejester commented 2 years ago

This looks fine now. Sorry about the delay.