search

ring-clojure / ring

Clojure HTTP server abstraction
MIT License
3.73k stars 518 forks source link

Add .xlsx extension to the mimetypes map #480

Closed rutchkiwi closed 1 year ago

rutchkiwi commented 1 year ago

I need this for some tests I'm writing using https://github.com/xeqi/peridot, which in turn uses this. But still would be nice to have if you're serving them with a web server or whatever I think.

I checked the MIME type and it is in here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types and it's what firefox sends when uploading XLSX too.

Thanks for your time!

rutchkiwi commented 1 year ago

@weavejester Would you have some time to check this one? It is just one line

weavejester commented 1 year ago

Sorry for the delay. It looks like you've typoed the minetype. You've put in the file path to the namespace, instead of the mimetype you linked to.

rutchkiwi commented 1 year ago

@weavejester facepalm sorry about that, fixed now. Thanks for taking the time!

weavejester commented 1 year ago

Merged. Thanks for the patch.