ringbahn / iou

Rust interface to io_uring
Apache License 2.0
328 stars 22 forks source link

Remove pub function 'is_timeout' #39

Closed ca7023 closed 4 years ago

ca7023 commented 4 years ago

AFAIK, LIBURING_UDATA_TIMEOUT should only be used within internal library i.e. liburing, it is set to user_data by calls like io_uring_wait_cqes, and the correspond cqe handled by __io_uring_peek_cqe, so it should used by users in any situations.

According to liburing/src/queue.c:

Applications using this function must never set sqe->user_data to LIBURING_UDATA_TIMEOUT!

mxxo commented 4 years ago

I think this is a dup of https://github.com/withoutboats/iou/issues/24

withoutboats commented 4 years ago

This is the correct choice. Given the refactors, I've reimplemented this as #53