search

ringbahn / uring-sys

liburing bindings
Apache License 2.0
33 stars 14 forks source link

uring poll ring is broken #22

Open glommer opened 4 years ago

glommer commented 4 years ago

This is because liburing broke it with their commit https://github.com/axboe/liburing/commit/f0c5c54945ae92a00cdbb43bdf3abaeab6bd3a23

It was fixed (by reverting) by https://github.com/axboe/liburing/commit/1bafb3ce5f5eeb11cd982c7540f6aa74e3f381d4, and then a unit test was added by https://github.com/axboe/liburing/commit/596413404af870f01a03d47f284b328758db1152

Could we update liburing to include at least those commits?

withoutboats commented 4 years ago

Ugh that's a shame.

I've been trying to keep released versions of uring-sys pinned to specific release commits of liburing, was a patch commit released? I notice its been nearly 3 months since liburing had a release, do you know if there is an 0.8 release planned soon?

If the answer to these questions is no I'll consider pinning to the fix commit and making a new release.

Either way, until I make a new release, you can fork, update the git submodule and make iou use your fork with a cargo patch. That way you're unblocked.

glommer commented 4 years ago

Hey, thanks! I am not blocked and indeed I am using private versions. I would like to move back to using your upstream eventually, so this is mostly so we can track that.

It does make sense to keep it pinned to release versions, thanks!

I can ask Axboe when he plans to release 0.8 and I'll get back to you

PureWhiteWu commented 3 years ago

Gello, seems liburing 2.0 is release now, do you plan to update to it? Thanks!