ringcentral / engage-digital-messaging-ios

Engage Digital Messaging IOS SDK
Other
10 stars 6 forks source link

Dimelo crash on iOS 10 and below #16

Closed leonovvalentin closed 6 years ago

leonovvalentin commented 6 years ago

Hello!

We have a crash related to using -[UIWindow safeAreaInsets] method which don't exist on iOS 10 and below. This bug seems appeared in 1.7.6 version of Dimelo.

It is crash repost from Crashlytics:

Fatal Exception: NSInvalidArgumentException
-[UIWindow safeAreaInsets]: unrecognized selector sent to instance 0x155e283d0
Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x18784afe0 __exceptionPreprocess
1  libobjc.A.dylib                0x1862ac538 objc_exception_throw
2  CoreFoundation                 0x187851ef4 __methodDescriptionForSelector
3  CoreFoundation                 0x18784ef54 ___forwarding___
4  CoreFoundation                 0x18774ad4c _CF_forwarding_prep_0
5  RechargesProj                  0x1005352a8 -[DimeloChatNotificationWindow layoutContainerForOrientation:]
6  RechargesProj                  0x100535610 -[DimeloChatNotificationWindow presentView:]
7  RechargesProj                  0x100535e0c -[DimeloChatNotificationWindow presentMessage:apiInstance:]
8  RechargesProj                  0x1005064dc -[Dimelo consumeReceivedRemoteNotification:]
9  RechargesProj                  0x1001e7b24 specialized DimeloChatService.loadRemoteNotificationPayload([AnyHashable : Any]) -> Bool (DimeloChatService.swift:155)
10 RechargesProj                  0x1001e20b4 DimeloChatServiceRechargesProjChatService (DimeloChatService.swift)
11 RechargesProj                  0x100440ffc specialized specialized AppDelegate.userNotificationCenter(UNUserNotificationCenter, willPresent : UNNotification, withCompletionHandler : (UNNotificationPresentationOptions) -> ()) -> () (AppDelegate.swift:252)
12 RechargesProj                  0x10043daa0 @objc AppDelegate.userNotificationCenter(UNUserNotificationCenter, willPresent : UNNotification, withCompletionHandler : (UNNotificationPresentationOptions) -> ()) -> ()
13 UIKit                          0x18dc0fa00 -[UIApplication _handleNonLaunchSpecificActions:forScene:withTransitionContext:completion:]
14 UIKit                          0x18dbfd90c -[UIApplication workspace:didReceiveActions:]
15 FrontBoardServices             0x1893f4884 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__
16 FrontBoardServices             0x1893f46f0 -[FBSSerialQueue _performNext]
17 FrontBoardServices             0x1893f4aa0 -[FBSSerialQueue _performNextFromRunLoopSource]
18 CoreFoundation                 0x1877f942c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
19 CoreFoundation                 0x1877f8d9c __CFRunLoopDoSources0
20 CoreFoundation                 0x1877f69a8 __CFRunLoopRun
21 CoreFoundation                 0x187726da4 CFRunLoopRunSpecific
22 GraphicsServices               0x189191074 GSEventRunModal
23 UIKit                          0x18d9e1c9c UIApplicationMain
24 RechargesProj                  0x100040340 main (RechargeMapFavouritesListCellViewModel.swift:16)
25 libdyld.dylib                  0x18673559c start

Thanks.

waelba commented 6 years ago

Hello @leonovvalentin

Thank you for reporting this, we have acknowledged this issue and are currently fixing it. You can expect a new release very soon.

DrissTM commented 6 years ago

Hi @leonovvalentin,

This will be fixed in the next release (v1.7.7)

I'll update this ticket to let you know as soon as we release the new version !

waelba commented 6 years ago

Hi @leonovvalentin,

You can test it on v1.7.7 now

leonovvalentin commented 6 years ago

It is OK now! Thanks for your timely response.