ringcentral / ringcentral-chatbot-js

RingCentral Chatbot Framework for JavaScript
MIT License
10 stars 7 forks source link

Update bot.ts #48

Closed dheereshagrwal closed 2 years ago

dheereshagrwal commented 2 years ago

there was a bug

tylerlong commented 2 years ago

Could you please elaborate how to reproduce the bug?

I have this demo project which just works: https://github.com/tylerlong/ringcentral-chatbot-dialog-demo

Appreciate if you could tell me how to reproduce the bug with the project above. Thanks.

dheereshagrwal commented 2 years ago

If you go to the package.json, it installs the ringcentral bot itself. The problem is in the ringcentral-chatbot-js

tylerlong commented 2 years ago

They are the same thing:

dheereshagrwal commented 2 years ago

Yeah, that I know, but the current code throws an error "Can't verify the redirect uri" when we add the bot without the line I added in bot.ts

tylerlong commented 2 years ago

The part you changed has no effect on bot adding. I believe it is just a coincidence that you made the change and it worked.

What affect bot adding is this part: https://github.com/ringcentral/ringcentral-chatbot-js/blob/master/src/apps/bot.ts#L10-L18

Again, steps to reproduce the issue are required. I don't want to make change without verifying it first.

dheereshagrwal commented 2 years ago

I will install it from the scratch, and reproduce the bug. Could we connect today as early as possible because of the timezone difference?

tylerlong commented 2 years ago

I tested it in production but I couldn't reproduce the issue. And yes there seems be to an issue in sandbox environment. I will go ahead and merge this PR.