ringcentral / ringcentral-integration-for-hubspot

Add RingCentral to HubSpot, so HubSpot user can call with RingCentral by Click HubSpot call button.
http://ringcentral-integration-for-hubspot.readthedocs.io/
7 stars 7 forks source link

Different UI for call provider #14

Open zxdong262 opened 3 years ago

zxdong262 commented 3 years ago

For most user, the call provider they see is like this:

Screen Shot 2021-01-28 at 6 35 55 AM

But for some user they see this, in this situation, calling sdk could not init, so can not get calling info for the iframe

Screen Shot 2021-01-28 at 6 38 03 AM
IsaacTakushi commented 3 years ago

Hi, @zxdong262.

Happy to take a closer look. I have two clarifying questions:

  1. If you click Open notes and call options (i) in the updated UI, does the popup show or give the option to select RingCentral as the calling provider? Could you share a screenshot of what appears?
  2. You said: "in this situation, calling sdk could init, so can not get calling info for the iframe." Did you mean to say "in this situation, [the] Calling SDK could NOT init"? I'm trying to understand exactly where you are encountering issues with the updated UI.
zxdong262 commented 3 years ago

@IsaacTakushi Thank you for the reply.

  1. It is from one user's screen, I can not check, as I remember, click Open notes and call options, do have a call provider selection UI.
  2. Yes, my mistake, I mean Calling SDK could NOT init, in my code there is something like this:
    init = () => {
    this.cti = new CallingExtensions({
      debugMode: false,
      eventHandlers: {
        onReady: () => {
          console.debug('CallingExtensions ready')

, that is why I think the SDK not init properly, I can not see the log info.

IsaacTakushi commented 3 years ago

Thank you for sharing this information, @zxdong262. I'll take a closer look and attempt to replicate in the new UI.

As I understand it, you are also not seeing any errors in the Network tab or Console?

IsaacTakushi commented 3 years ago

Hey, @zxdong262.

I confirmed that in the v2 calling widget, users must click Open call options and select RingCentral as the Calling Provider if the last call was not made using RingCentral.

This screen capture shows what I am seeing in my own account: RingCentral_Calling_Provider

Can you confirm whether you are seeing the calling extension initiate after taking these steps?

If you are not seeing the Calling Provider dropdown populate in the widget, try updating your localStorage with this new path:

localStorage.setItem(
  "LocalSettings:Calling:CallingExtensions",
  '{"name": "RingCentral", "url": "https://XXXXXXX.execute-api.us-east-1.amazonaws.com/prod/app"}'
)
zxdong262 commented 3 years ago

@IsaacTakushi

I do not have a UI like this in my test account.

Do you mean user select RingCentral once, then the calling SDK will init properly and show the log 'CallingExtensions ready', can you confirm that you can see the log 'CallingExtensions ready' in console?

IsaacTakushi commented 3 years ago

Hey, @zxdong262.

Apologies, I forgot to mention how to get this UI in your test account:

To opt into the beta:

  1. Navigate to any CRM object record (e.g. contact)
  2. Click the Try the new calling experience button in the lower-left corner
  3. Select Try beta from the menu

See the screenshot below: Try Beta

To opt out of the beta:

  1. Navigate to any CRM object record (e.g. contact)
  2. Click the Calling beta options button in the lower-left corner
  3. Select Leave beta from the menu

See the screenshot below: Leave Beta

If you are not seeing the beta button in the lower-left corner, please let me know.

I don't see the exact message CallingExtensions ready in my console but I was able to make a successful call to my own phone number via the new calling widget. Here are some of the messages which appeared in my console:

 Successful Call with New Widget

zxdong262 commented 3 years ago

@IsaacTakushi I think I know it now, when switch to beta UI, calling info provide subjectId instead of objectId in common UI Screen Shot 2021-02-03 at 8 58 18 AM Screen Shot 2021-02-03 at 9 03 17 AM