search

ringcentral / ringcentral-js

RingCentral Connect Platform JS SDK
MIT License
63 stars 56 forks source link

Remove Playwright as a postinstall step #267

Closed ganderzz closed 2 months ago

ganderzz commented 2 months ago

Hey all,

We see periodic flakiness in CI builds because this package has a post-install script in the SDK that installs Playwright. This is not only a bad security practice, but is Playwright being used in the codebase? If so, it should be added as a devDependency so consuming apps don't download Playwright and subsequent dependencies (webkit, firefox, etc).

https://github.com/ringcentral/ringcentral-js/blob/c86b8777fe34b2646dae79d9153352f74f2bbf23/sdk/package.json#L5

I am open to making the changes and creating a PR!

tylerlong commented 2 months ago

@embbnux It's introduced here: https://github.com/ringcentral/ringcentral-js/commit/5451c5a2687c79da3b1cb4bd5ed9ae6ef2e3a45c We are not using playwright at all. Please remove the postinstall script. Thanks

SushilMallRC commented 2 months ago

Hi @ganderzz @tylerlong , Changes have been made in the PR https://github.com/ringcentral/ringcentral-js/pull/268 and will update here once the new version is released. Thank you for pointing it out.

SushilMallRC commented 2 months ago

A new version, 5.0.3, has been released, which includes a fix for this issue. Closing this issue for now please feel free to reopen or create a new one. Thank You.

ganderzz commented 2 months ago

Thanks @SushilMallRC !