ringcentral / ringcentral-python

RingCentral Connect Platform Python SDK
MIT License
43 stars 35 forks source link

Update api_response.py #62

Closed LohithNarayan closed 12 months ago

LohithNarayan commented 1 year ago

Code change from

message = message + ' (and additional error happened during JSON parse: ' + e.message + ')'

message = message + ' (and additional error happened during JSON parse: ' + str(e) + ')' n Python 3.x and modern versions of Python 2.x use except Exception as e instead of except Exception, e:
tylerlong commented 1 year ago

n Python 3.x and modern versions of Python 2.x use except Exception as e instead of except Exception, e:

I don't quite understand this sentence. And you didn't change except Exception as e or except Exception, e.

Since we are trying to fix an issue of fax sending(https://github.com/ringcentral/ringcentral-python/issues/54). We need some testing code (either unit tests or a separate demo project) to verify that fax is working.

tylerlong commented 1 year ago

Since https://github.com/ringcentral/ringcentral-python/pull/64 is working fine. Is this PR still necessary?