search

ringmesh / RINGMesh

RINGMesh is a C++ open-source platform for manipulating meshes of geological models.
http://ringmesh.org
BSD 3-Clause "New" or "Revised" License
70 stars 16 forks source link

Ringmesh libs #70

Closed BotellaA closed 6 years ago

BotellaA commented 6 years ago

First implementation of several libraries in RINGMesh. Libraries are automatically initialized at loading.

francoisbonneau commented 6 years ago

Is their anything to do on this pr?

BotellaA commented 6 years ago

SonarQube analysis reported 30 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR stratigraphic_column.h#L261: Remove this unused "layer_" "private" field. rule
  2. MAJOR stratigraphic_column.h#L537: Remove this unused private function. rule
  3. MAJOR tetgen_mesher.h#L80: Remove this unused private function. rule
  4. MAJOR tetgen_mesher.h#L83: Remove this unused private function. rule
  5. MAJOR tetgen_mesher.h#L84: Remove this unused private function. rule
  6. MAJOR tetgen_mesher.h#L85: Remove this unused private function. rule
  7. MAJOR tetgen_mesher.h#L86: Remove this unused private function. rule
  8. MAJOR tetgen_mesher.h#L90: Remove this unused private function. rule
  9. MAJOR tetgen_mesher.h#L92: Remove this unused private function. rule
  10. MAJOR tetgen_mesher.h#L93: Remove this unused private function. rule