Mime types (issue #4) - Githubissues

ringo-framework / ringo_printtemplates

GNU General Public License v2.0

1 stars 2 forks source link

Mime types (issue #4) #5

Closed ghost closed 7 years ago

ghost commented 7 years ago

PR for issue #4.

There is still a TODO, which I cannot solve myself:

In views.py:138 I return None if the check for a proper template fails.

There should be something else, because the following code (printtemplates, mako renderer, pyramid) don't handle None well. So, for now there will be a server error after the file type check fails.

ghost commented 7 years ago

I changed the error handling as discussed (raises a 500 server error with meaningful information where it previously failed)

ghost commented 7 years ago

(I squished my commits to avoid clutter)

removed superfluous checks
added validation if there is actually some data to validate. This should be required in the form at first submission, because it is not advised to use a non-existing template.