ringo / stick

JSGI middleware composition layer and application framework
Other
47 stars 17 forks source link

Mounts not sorted prior to searching #5

Open oravecz opened 13 years ago

oravecz commented 13 years ago

If I have the following two mounts defined: app.mount('/', module.resolve('test1/config')); app.mount('/test2', module.resolve('test2/config'));

The first one will always match the incoming url. It is probably best to sort the mounts by least specific prior to matching. Least specific in this case would be determined by the number of slashes in the spec.path. In the above example, the trailing slash is removed from all paths, so the first mount actually becomes "" and the second is "/test2".

oravecz commented 13 years ago

Fixed by pull request

oberhamsi commented 11 years ago

the pull branch is gone. did this really work? :) only for mount and not route? was it a good idea?