search

ringosham / Lazer-exporter

A utility for importing and exporting beatmap list, as well as extracting songs and beatmaps installed in osu!Lazer
Apache License 2.0
34 stars 1 forks source link

Problem with exporting music #10

Closed otiskujawa closed 4 years ago

otiskujawa commented 4 years ago

at the beginning I had a problem only with changing the cover of the songs but now I have a problem with downloading music image The download stops in this position and does not move. Before I had a similar problem, but after downloading music and changing to an mp3 file changing covers and tags stopped on one of the songs (usually in half). I only had this problem when I chose to download covers. Only some songs had covers and used playable names such as -. There is my beatmaps

otiskujawa's beatmaps.txt

ringosham commented 4 years ago

This is going to take some time to debug as there's a lot to download.

otiskujawa commented 4 years ago

image Yes

ringosham commented 4 years ago

Sorry for the silence. I finally got time to look at this.

Importing the beatmaps are a total pain due to the beatmap importing system of the game itself is on a half-working state. The game marked them with totally wrong beatmap IDs which not only causes leaderboards to not show up but broke the app as well.

I may need a few more days before I can tackle the issue.

otiskujawa commented 4 years ago

Ok, I can wait up to several weeks

ringosham commented 4 years ago

It seemed the app failed to read one of the mp3s and the whole thing just crashed.

The audio file reader is not made by me so I can't really fix this without looking deep in others work. I'll make it so that it will skip any unreadable mp3 files for now.

Edit: After spending a bit more time, I found out that apparently the app already does that. It crashed when trying to display the error message.

ringosham commented 4 years ago

Please check out the new release.

You may notice a lot of errors popping up in the log. If it is about errors relating to the audio file, that's likely due to my dependencies are too outdated. I may update those when I have the time. If it is about audio files not found, blame osu!lazer. Cause that's not supposed to happen.

otiskujawa commented 4 years ago

Can you add skip option for errors ? Beatmap 119 AKITO - Sakura Kagetsu has no audio file NullPointerException : null Failed processing song: 332 Sigh - Midnight Sun NullPointerException : null Failed processing song: 573 Steel Angels - Kiss Kara Hajimaru Miracle NullPointerException : null Failed processing song: 648 Dethklok - Duncan Hills Coffee Jingle NullPointerException : null Failed processing song: 698 RIZE - Lady Love NullPointerException : null Beatmap 73 LM.C - BOYS & GIRLS has no audio file NullPointerException : null Failed processing song: 96 - Speed Over Beethoven InputFormatException : Error while opening file Beatmap 351167 Kana Hanazawa - Renai Circulation has no audio file NullPointerException : null Failed converting song. Keeping ogg format: Let's Dance - Delaney Wolff it.sauronsoftware.jave.EncoderException : Error while opening codec for output stream #0.0 - maybe incorrect parameters such as bit_rate, rate, width or height Cannot read album art. Skipping album art for Fire Emblem Theme (Brawl Version) - Shogo Sakai java.lang.IllegalArgumentException : image == null!

image

Now the files have been exported but not all have new tags. Thank you for your help

otiskujawa commented 4 years ago

image

ringosham commented 4 years ago

The app will continue to function despite the errors, meaning it already skips the files affected. It will just display them just to let you know something went wrong instead of nothing. You can safely ignore them.

About the album arts, this is also normal. Many music players, including Windows itself. Don't like album arts at anything other than 1:1 aspect ratio. They will sometimes outright refuse to read them.

ringosham commented 4 years ago

I can't reproduce the missing title and author tags however.

otiskujawa commented 4 years ago

Ok Finaly i can make .. 32 hours of music in one playlist image