search

ringosham / TranslateMod

A chat translation mod for Minecraft
https://www.curseforge.com/minecraft/mc-mods/real-time-chat-translation-mod
GNU General Public License v3.0
15 stars 6 forks source link

Extreme performance loss translating signs (mostly modded ones) 1.16.5 #19

Open Kaleidio opened 2 years ago

Kaleidio commented 2 years ago

https://spark.lucko.me/NtrZXsXOss

the above is a possible incompat with Performant mod, but I doubt it

also causes logspam with optifine render regions enabled:

[13:59:20] [Render thread/ERROR]: [OptiFine] OpenGL error: 1281 (Invalid value), at: Copy VBO range [13:59:20] [Render thread/ERROR]: OpenGL API ERROR: 1281 (GL_INVALID_VALUE error generated. neither nor can be negative.)

Kaleidio commented 2 years ago

image focused on your mod

ringosham commented 2 years ago

This seems to be an easy fix.

Kaleidio commented 2 years ago

sounds to me like you don't cache results?

ringosham commented 2 years ago

Nah. This is just a small mistake. It should not process things on the server at all in the first place. Everything should stay client side. I'm also in the processing of porting it to 1.17.1 so updates might take a while to release

Kaleidio commented 1 year ago

nothing has been done to the 1.16.5 to fix the issue, is this issue abandoned or patched or only in newer mc versions?