ringrunnermg / Ringcon-Driver

MIT License
120 stars 18 forks source link

press or pull function not working #2

Open Taejunejung opened 3 years ago

Taejunejung commented 3 years ago

Hello. First of all, thank you for developing such a good program.

I want to play Dark Souls 3 with Ringcon driver.

However, the pressing operation does not work in "Ringcon Full RH" (mode2) state.

The pull operation does not work even in default mode. (In debug mode, the incoming value is checked. However, the buttons or analog values ​​on the gamepad are not recognized.)

When I guessed through this, it seems that only the state that the input from the sensor reference is pressed is working.

Also, there is no distinction between heavy press (or pull) and light press action.

I tried to fix it myself, but it failed to configure the build environment, leaving an issue.

Thank you.

ringrunnermg commented 3 years ago

In Ringcon Full RH mode the heavy press is deliberately disabled as it goes outside the flex sensors range. It sounds like you may be having an issue with the light press/pull not working...

Could you try to install the Ringcordian program which has a visualiser and see what the ring thinks it is doing: https://github.com/ressium/Ringcordion

Taejunejung commented 3 years ago

https://clips.twitch.tv/YummySparklyMagpieWow-WU1HoBjyCC3IkTzk

Pulling and pressing function works.

But, As shown in the video link, Ringcon is recognized as press state even in idle state.

I tested it with another pair of controllers to check whether the controller is malfunctioning, but the result is the same.

One of my viewers tried the same thing and got the same result.

In switch, Ringcon was confirmed to operate normally.

thanks

gabitsfd commented 3 years ago

☝ original : https://clips.twitch.tv/YummySparklyMagpieWow-WU1HoBjyCC3IkTzk translation : https://youtu.be/HtAjJTRL7H4

Taejunejung commented 3 years ago

Joy-con's input value was 245-255-10 on my side. (unlike 0-10-20).

So I solved it myself, but I found that there's new problem during the test.

When I push the ring-con multiple times fast and quick,

Only push and pull input don't works until I reset the driver and program.

https://clips.twitch.tv/IronicShyCobblerTTours-xRqdOi4KW4s0RpCz

ringrunnermg commented 3 years ago

Hmmm I thought the July update may have thrown off the calibration data so updated mine but it is still working as it should. For your fix did you add 10 to the Ringcon value before using it in the program or did you change the push/pull functions to match 245-255-10?

I can also not replicate the push/pull breaking issue, that looks like it may be a bit trickier to sort out.

Taejunejung commented 3 years ago

I changed the press and pull functions to match the 245-255-10.

I also tested the 1.0.1 build to see if the problem was caused by my code modification.

The result is the same problem.

The problem first occurs with the "buf" variable.

My guess is that the problem occurs when 5 or more "heavy press<->heavy pull" is repeated quickly.

Both mode1 and mode2 show the same problem.

Lonce32 commented 3 years ago

My press and pull function are also not working, I tried it in the ringcordion and the press and pull aren't working as well as the strap con dosen't work in debug mode.

Lonce32 commented 3 years ago

Tested it out a little more, all the buttons work

ringrunnermg commented 3 years ago

Hello @Taejunejung could you please check the new version of the Ringcon driver and see if the "Ringcon fix" option works for you. Any feedback would be great.

jonaskindler93 commented 3 years ago

I have similar problems. I try to visualise the emulated controllers presses with joyToKey. By default button5 always seems to be active. When I press hard Button11 gets enabled. Pulling hard enables button6. I'd assume that button5 is always enabled and should correspond to light pressing and because of wrong calibration it always stays active? Values that are output by our logs is 13,14 when I don't press or pull.

ringrunnermg commented 3 years ago

Hmmm I must be missing something with the calibration. The default value should be sitting around 10 as you have probably figured out. I will add some way to manually adjust the default Ringcon value in the next update. So in your case you could add a -3 offset to the value to bring it back to correct, not sure what other issues this may bring up though...

jonaskindler93 commented 3 years ago

Any way I can do this myself to verify before you spend more time on it? Plus I'm excited to use the controller lol.

ringrunnermg commented 3 years ago

Not -3 but if you push the "Ringcon Fix" option it should add a constant of +10. If this is the case then the offset idea should work, if not then it is back to the drawing board.

jonaskindler93 commented 3 years ago

It does add 10 (value now defaults at 23). Furthermore joytokey now shows Button11 (I assume heavy push) permanently pressed, that confirms the theory.

ringrunnermg commented 2 years ago

Hi @jonaskindler93, I have just released V1.0.3 which has a slider for the Ringcon fix so you can choose -3 and fix the incorrect calibration. If this works then it would pay to change the "config.txt" file so ringconfix is -3 instead of 0, this would save you from having to correct it every time.

jonaskindler93 commented 2 years ago

Thank you! I will try it out after the weekend!

Yasyara commented 1 year ago

help with the JoiCon problem: https://github.com/ringrunnermg/Ringcon-Driver/issues/22?ysclid=llhxsz6lkk27258939