ringw / vexflow

A JavaScript library for rendering music notation and guitar tablature.
http://www.vexflow.com
71 stars 23 forks source link

Move MusicXML support into a separate package (not a fork)? #9

Closed nickolay closed 8 years ago

nickolay commented 8 years ago

Have you seen https://github.com/mechanicalscribe/vexflow-musicxml ? It packages your MusicXML work separately from the base vexflow.

Apart from reducing the branch-syncing hassle, it also makes it possible to include a MusicXML-specific README and a demo, and makes it clear that MusicXML support is actually separate code building on vexflow, not a true fork. I think this makes it more approachable for possible contributors.

Would you consider switching the canonical repository from being a fork of vexflow to being a separate package depending on it?

For the reference, the repo I mentioned is behind the canonical code at the moment - and also adds some local changes, - so the following two commits are "synced":

It also doesn't include the tests and added samples.

ringw commented 8 years ago

Thanks. I really like this layout, and I've merged it. I'll mention @wilson428 too, hopefully he sees this.

wilson428 commented 8 years ago

Thank you both!