search

rinigus / mapbox-gl-qml

Unofficial Mapbox GL Native bindings for Qt QML
GNU Lesser General Public License v3.0
38 stars 10 forks source link

Crash at high zoom levels for RTL countries #39

Closed rinigus closed 5 years ago

rinigus commented 5 years ago

As reported by @planetos in https://github.com/rinigus/pure-maps/issues/121

Unfortunately now the app closes/crashes if I zoom into an OSM map as soon as I reach zoom-level 1km - according to the measure in lower left corner. This happens where languages are written from right to left. Tested on Sailfish on ARM.

Further observations:

I can reproduce it with Lebanon, on phone (SFOS) and on desktop. When using QtLocation based map viewer there is no crash. So, something is wrong with BiDi handling in QMapboxGL version compiled by me. In my version, the library is compiled with use_icu flag that uses platform/default/bidi.cpp to render RTL languages correctly (same didn't work with platform/qt/src/bidi.cpp).

Would have to check how to make platform/qt/src/bidi.cpp to work correctly and not lead to https://github.com/rinigus/pure-maps/issues/121 . I presume that Qt version is used in QtLocation and there it works as expected.

/cc @planetos

rinigus commented 5 years ago

Update: found the commit that fixed the issue. Now will look into update of qmapboxgl library to incorporate that. At least, we are on the way to fix it

rinigus commented 5 years ago

Fixed with 1.5.0.0 release

rinigus commented 5 years ago

@planetos: the updated version was released at OpenRepos.