search

rinikerlab / GHOST

MIT License
48 stars 13 forks source link

Add a python package for GHOST #1

Closed greglandrum closed 3 years ago

greglandrum commented 3 years ago

This extracts Carmen's code for doing the threshold shift from the published notebooks, does a minor amount of tweaking, and makes it available as a standard python package. In a next step I'll add the infrastructure to allow us to make this available via either conda or pypi.

My main goal here is to make sure that @cespos and @sriniker are ok with the way I've structured things and the addition of the MIT license.

I need to do some more cleanup of the example notebook for the package (library_example.ipynb) so that there's a good example for how to use the package, but I will also do that in a second step.

sriniker commented 3 years ago

Looks good from my side

cespos commented 3 years ago

Hi Greg, It looks great! Thank you so much for doing that! You transformed my few, not really optimized lines of code, into something that others can use!

Il giorno mar 2 feb 2021 alle ore 22:37 sriniker notifications@github.com ha scritto:

Looks good from my side

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rinikerlab/GHOST/pull/1#issuecomment-772007951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHO5XT4DHYYM2POIJHRLOZTS5BWCFANCNFSM4W7AXMZA .