Closed pultar closed 2 years ago
Merging #296 (b011669) into main (7b717d5) will increase coverage by
0.06%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 54.54% 54.60% +0.06%
==========================================
Files 93 93
Lines 14358 14372 +14
==========================================
+ Hits 7831 7848 +17
+ Misses 6527 6524 -3
Flag | Coverage Δ | |
---|---|---|
unittests | 54.60% <100.00%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pygromos/files/trajectory/trc.py | 89.96% <100.00%> (+1.60%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I will need to double check @LaurianeJD It looks like an edge case but we should also account for these cases.
I will need to double check @LaurianeJD It looks like an edge case but we should also account for these cases.
Seems like a problem with numerical precision. We double checked with another system (menthol, included in test files) and re-calculated dihedrals with Chemcraft and Pymol. Values seem to be consistently stable but slightly off.
I believe it's close enough.
Description
Implement
mdtraj
functions to calculate angles and dihedrals in trajectories. Tests with dummy data are provided. Results can be requested in degrees (default) and radians via a flag.Todos
Status