rinikerlab / reeds

This pipeline is executing a RE-EDS run for relative free energy calculations. It can be used for example for calculation of hydration free energies or ligand binding free energies.
https://rinikerlab.github.io/reeds/
MIT License
30 stars 8 forks source link

Pot Threshold Correction #32

Closed RiesBen closed 3 years ago

RiesBen commented 3 years ago

Description

The code here is not doing what it is supposed to do. I'm adapting the code, such it does what is described in the manuscript and as we discussed. After this no code changes more on the main branch for now.

31

Todos

Notable points that this PR has either accomplished or will accomplish.

Status

RiesBen commented 3 years ago

Hi, ok now it escalated a bit but I added now even some more stuff, than I wanted.

For all RE-EDS Modules:

RiesBen commented 3 years ago

+update of docs

RiesBen commented 3 years ago
SalomeRonja commented 3 years ago

Fixed the plotting bug in the eoff vs s plot as discussed.

Old plot: RE-EDS_eoffs_vs_s

Buggy plot: eoffs_vs_s

New plot: eoffs_vs_s_new

RiesBen commented 3 years ago

Fixed the plotting bug in the eoff vs s plot as discussed.

Old plot: RE-EDS_eoffs_vs_s

Buggy plot: eoffs_vs_s

New plot: eoffs_vs_s_new

Thanks for checking this and fixing it! 👍

RiesBen commented 3 years ago

Everything looks good from my side! Thanks a lot for your work Benjamin :)

Thanks for the nice review and finding the namings!