search

rinja-rs / rinja

A template rendering engine based on Jinja, generating type-safe Rust code at compile time.
https://rinja.readthedocs.io
Apache License 2.0
116 stars 10 forks source link

Remove useless `indent` information from `Buffer` #4

Closed GuillaumeGomez closed 3 months ago

GuillaumeGomez commented 3 months ago

First real PR for this project. :)

Kijewski commented 3 months ago

Good call! Maybe we can later add a prettyprint feature to indent the generated code using prettyplease, but I think that's very low on my TODO list.

With this change Buffer::writeln is infallible. Do you want to remove the Result type result?

GuillaumeGomez commented 3 months ago

Good call, let's remove it. :)

GuillaumeGomez commented 3 months ago

Done!

GuillaumeGomez commented 3 months ago

I'll wait for you to merge this to ensure I correctly set up the team settings.

Kijewski commented 3 months ago

Thanks! I have a "merge" button now, but I don't have the privileges to add hooks.

GuillaumeGomez commented 3 months ago

Let me fix that. :)