rinpharma / r-pharma

R in Pharma
https://rinpharma.com
MIT License
36 stars 12 forks source link

Rebuilding site does not run build_team script #240

Closed harveyl888 closed 1 year ago

harveyl888 commented 1 year ago

@epijim - looks like GitHub actions does not run the build_team.R script when triggering a rebuild (just noticed this when editing org committee spreadsheet).

Noticed in .github/workflows line is commented out. Any reason?

#- name: Build team # run locally
#  run: Rscript -e 'source("build_scripts/build_team.R")'
epijim commented 1 year ago

I don't remember why... I uncommented and it ran ok, but hasn't updated on the site (but sometimes there is a lag on pages, so will check again in a bit)

harveyl888 commented 1 year ago

I see update on site and all looks well. Thanks so much James!

harveyl888 commented 1 year ago

One thing - I noticed that Devin and Elizabeth are still included even though they are dropped from spreadsheet. Guessing it's related to not starting with a clean authors folder (something we can't do as we use the same folder for keynotes). I'll remove them from existing author folder to see if it helps.
Update: looks like it worked 😄