search

rinq / rinq-go

A cross-language command bus and distributed ephemeral data store.
Other
17 stars 1 forks source link

Collapse `localsession.state` and `localsession.session` into a single struct. #156

Closed jmalloc closed 7 years ago

jmalloc commented 7 years ago

@koden-km FYI this PR isn't ready, but I'd appreciate if you could have a look through the progress so far.

jmalloc commented 7 years ago

Ok, I believe it's ready now.

jmalloc commented 7 years ago

Note that although I've collapsed the two structs into one, I've kept the implementation in two separate files. session.go contains the implementation of rinq.Session, and the "lower level" API logic that was previously part of the state struct is in session_state.go.

The diff of session.go is quite large, I'd say it's probably a lot easier to view in "split" view, rather than "unified".

koden-km commented 7 years ago

Looks cleaner with less error handler juggling.