search

rintoj / ngx-virtual-scroller

Virtual Scroll displays a virtual, "infinite" list.
https://rintoj.github.io/ngx-virtual-scroller
MIT License
979 stars 295 forks source link

chore: update to angular 10 #468

Closed Michsior14 closed 1 year ago

Michsior14 commented 4 years ago

Fixes: #457

whyboris commented 4 years ago

@speige -- while I have repository rights to merge the commit, I would feel safer if you glance over it and do it 🤝

I think this is an excellent change and I look forward to it getting merged 🙌

ahnpnl commented 4 years ago

hi, are there any updates on this ?

SvenBudak commented 4 years ago

@rintoj if this package fix some problems, maybe accept the merg reuqest? :) We have currently problems to make this package work in latest angular version... a fix would be great

whyboris commented 4 years ago

@speige or @vanackere -- as far as I can tell this is a great PR that is safe to merge; please confirm if you have time and merge 🙇

vanackere commented 4 years ago

@whyboris fine with me to merge this... (but I'm not sure who can publish a new release on npm even once this is merged if the original maintainer is missing...)

SvenBudak commented 4 years ago

@vanackere What is with rintoj? he cant publish anymore packages on npm?

vanackere commented 4 years ago

@Michsior14 could you please rebase your branch and resolve the conflicts in demo/package-lock.json ?

vanackere commented 4 years ago

@vanackere What is with rintoj? he cant publish anymore packages on npm?

@SvenBudak : all I meant is that if @rintoj is not available to merge this pull request, he probably doesn't have time either to push a new release on npm...

SvenBudak commented 4 years ago

I work with a friend on a open source lib. its in early progress. here is the first documentation entry: https://devmonkeysde.gitbook.io/mark6/components/image

We plan to use ngx-virtual-scroller for our messenger. but we have a huge problem: https://imgur.com/ShYjIJj It seems that the scroller cant handle the dynamic heights of the items. Here in live: https://mark6-demo.web.app/messenger (Please check it in Device Emulator in chrome for example, with smartphone.)

If @rintoj is okay with this idea, can we maybe add ngx-virtual-scroller to mark6? just an idea :)

Sampath-Lokuge commented 4 years ago

Can we have this release soon? i.e Angular 10 support?

Sampath-Lokuge commented 3 years ago

Hi, @speige Any feedback about this release?

whyboris commented 3 years ago

@rintoj -- this seems like a great PR, do you have a comment on this? 😊

tiagodev commented 3 years ago

the last release was almost a year ago... is this project dead?

SvenBudak commented 3 years ago

@tiagodev There is one thing i learned in last years.. never try to use any virtual scroll lib. they are NEVER working. just try to solve your apps without it.

whyboris commented 3 years ago

@tiagodev - this project is not dead, it works perfectly well. Just because it's not updated with the latest version of everything, doesn't mean it's not worth using.

@SvenBudak please reflect on your comment. This is a production-ready project that is used in free and commercial applications. I'm sorry to hear you have had trouble with libraries. But given that there are close to 1,000 stars on this repository (with thousands of users successfully implementing this library), your advice seems inappropriate. Please consider how rude it would be to be standing next to someone who freely is sharing their work to help others, and to just say an equivalent of what you just said. Are you actively trying to discourage people from building things with intention of helping others?

tiagodev commented 3 years ago

@whyboris glad to hear that. I've been using it for a long time already and I was just wondering why the long wait since there's activity around here.

SergioGMB commented 3 years ago

I'm sorry to tag you, but someone can merge and release this? @whyboris Thanks a lot!

whyboris commented 3 years ago

I have the repository rights to merge but I don't have the ability to craft the npm release. @rintoj -- would you be willing to create a new release if this gets merged? If so, I will do a thorough pass on the PR before merging 👌

ggallotti commented 3 years ago

Any news about this?

denniske commented 3 years ago

@whyboris @speige If you have the time, I suggest creating a new repo ngx-virtual-scroller-next. Do a feature freeze and only update the library to work with the latest angular version. Publish a new npm package ngx-virtual-scroller-next.

This would greatly increase the value of this project and encourage people to use it.

nerumo commented 1 year ago

why closed?

Michsior14 commented 1 year ago

why closed?

This project looks dead too me and I am not interested in keeping it up to date nor implement any feedback.

Sampath-Lokuge commented 1 year ago

Try this and compatible with the latest Angular: https://github.com/lVlyke/lithium-ngx-virtual-scroll

nerumo commented 1 year ago

Try this and compatible with the latest Angular: https://github.com/lVlyke/lithium-ngx-virtual-scroll

wow, thank you

rooby commented 1 year ago

Here is a fork of ngx-virtual-scroller that has a reasonable amount of users: https://www.npmjs.com/package/@iharbeck/ngx-virtual-scroller

nerumo commented 1 year ago

Here is a fork of ngx-virtual-scroller that has a reasonable amount of users: https://www.npmjs.com/package/@iharbeck/ngx-virtual-scroller

I know, but there are new performance features (async rendering and caching) that I missed

ichepurnoy commented 1 year ago

why closed?

This project looks dead too me and I am not interested in keeping it up to date nor implement any feedback.

@Michsior14 There is an +/- actively maintained fork, updated for Angular 16 https://www.npmjs.com/package/@iharbeck/ngx-virtual-scroller . Could you please consider making a PR to that repo? Thank you for your efforts!