Have Plugin#OnDisable actually be called

rinukkusu / Shinkei

an IRC bot written in C# with a massive plugin system.

GNU General Public License v3.0

7 stars 0 forks source link

Have Plugin#OnDisable actually be called #5

Open Shadow1Raven opened 8 years ago

Shadow1Raven commented 8 years ago

Even though it is declared OnDisable is never actually called. It would be much appreciated if the honourable master of this project were to show endeavour of implementing the functionality in question.

rinukkusu commented 7 years ago

When do you expect OnDisable to be called? Like when you press Ctrl+C?

Shadow1Raven commented 7 years ago

I'm not sure at which point it would make the most sense. I guess it would make sense if the dependencies (including the plugins the one OnDisable is called on depends upon) were still loaded. I'm not sure when or where the best place for this would be to ensure this. I guess after pressing CTRL+C would be a good time to quit the program, though.