Closed DSpeichert closed 1 year ago
Code Climate has analyzed commit 7c007acc and detected 0 issues on this pull request.
View more on Code Climate.
This seems to be a wrong misconfigured PR, kindly double check the modifications, and submit again. Thanks!
@Omranic Could you please explain what appears to be wrong with the changes proposed?
I think this is the only place where those erroneously defined subdivision codes need to be corrected, is it not?
Try to compare both files side by side to see what I mean 🙂 Feel free to fix and update again, I'll be happy to re-consider.
On your screenshot, it looks like you're comparing resources/data/pl.json
with resources/divisions/pl.json
.
If you look at Files changed tab, you can see only the IDs of the divisions were changed in this PR, nothing to do with the resources/data/pl.json
file.
@DSpeichert Thank you for pointing this out, my bad, wrong file comparison!
Now I see what you mean, now I seem to understand this update. Let me fix that.
see: https://en.wikipedia.org/wiki/ISO_3166-2:PL