search

rinvex / countries

Rinvex Country is a simple and lightweight package for retrieving country details with flexibility. A whole bunch of data including name, demonym, capital, iso codes, dialling codes, geo data, currencies, flags, emoji, and other attributes for all 250 countries worldwide at your fingertips.
https://rinvex.com
MIT License
1.64k stars 206 forks source link

pl: ISO 3166-2 subdivision codes fixed #225

Closed DSpeichert closed 1 year ago

DSpeichert commented 2 years ago

see: https://en.wikipedia.org/wiki/ISO_3166-2:PL

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 7c007acc and detected 0 issues on this pull request.

View more on Code Climate.

Omranic commented 2 years ago

This seems to be a wrong misconfigured PR, kindly double check the modifications, and submit again. Thanks!

DSpeichert commented 2 years ago

@Omranic Could you please explain what appears to be wrong with the changes proposed?

I think this is the only place where those erroneously defined subdivision codes need to be corrected, is it not?

Omranic commented 2 years ago

Try to compare both files side by side to see what I mean 🙂 Feel free to fix and update again, I'll be happy to re-consider.

Screen Shot 2022-05-15 at 1 23 52 PM copy
DSpeichert commented 2 years ago

On your screenshot, it looks like you're comparing resources/data/pl.json with resources/divisions/pl.json.

If you look at Files changed tab, you can see only the IDs of the divisions were changed in this PR, nothing to do with the resources/data/pl.json file.

Omranic commented 1 year ago

@DSpeichert Thank you for pointing this out, my bad, wrong file comparison!

Now I see what you mean, now I seem to understand this update. Let me fix that.