search

rinvex / countries

Rinvex Country is a simple and lightweight package for retrieving country details with flexibility. A whole bunch of data including name, demonym, capital, iso codes, dialling codes, geo data, currencies, flags, emoji, and other attributes for all 250 countries worldwide at your fingertips.
https://rinvex.com
MIT License
1.64k stars 205 forks source link

Add missing country divisions #23

Closed Omranic closed 2 years ago

Omranic commented 7 years ago

There's still missing divisions for the following countries:

sebwalk commented 7 years ago

What are divisions? If you explain, I can definitely help! :)

Omranic commented 7 years ago

@hiwye Cool, that would be appreciated help. Divisions are administrative or political states of the countries, sometimes called divisions, others call it states, but mostly it depends on each country. For example there's 16 divisions in Germany (a.k.a. States of Germany) Reference

sebwalk commented 7 years ago

Where in the JSON schema would I add them?

Omranic commented 7 years ago

Every country must have it's own division file, and you can add missing data as new files to the following directory: https://github.com/rinvex/country/tree/develop/resources/data Please make sure to follow the same schema of other divisions, example from eg.divisions.json:

{
    "ALX": {
        "name": "Al Iskandariyah",
        "alt_names": [
            "El Iskandariya",
            "al-Iskandariyah",
            "al-Iskandarīyah",
            "Alexandria",
            "Alexandrie",
            "Alexandria"
        ],
        "geo": {
            "latitude": 31.2000924,
            "longitude": 29.9187387,
            "min_latitude": 31.1173177,
            "min_longitude": 29.8233701,
            "max_latitude": 31.330904,
            "max_longitude": 30.0864016
        }
    },
}

The name must be in English, while alt_names represents the alternative names in any languages (optional), finally the geolocation data is mandatory. You can submit one country per commit, or even per PR, it's OK 👍

Contribution Guide

Appreciated in advanced @hiwye 😃

akeebismail commented 7 years ago

Ok i need subdivisions of states in Nigeria. could not get it da may be i can be of help

Omranic commented 7 years ago

@damiz11 Well, I can see Nigeria's divisions already included in this package, so would you explain what's missing please? And of course, if you can do a PR I'd be happy to accept 😉

akeebismail commented 7 years ago

OK thanks, there some province in Nigeria that is not their, Local Government Area, it belong to the state, that is the divisions under the state data. so i need it. so can put me through how i can add it if i can. thanks for replying

On Wed, Apr 26, 2017 at 7:55 AM, Abdelrahman Omran <notifications@github.com

wrote:

@damiz11 https://github.com/damiz11 Well, I can see Nigeria's divisions already included in this package, so would you explain what's missing please? And of course, if you can do a PR I'd be happy to accept 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rinvex/country/issues/23#issuecomment-297257455, or mute the thread https://github.com/notifications/unsubscribe-auth/ASTs0MuJv0MkDV4MDY-6HjLuug2KO_d8ks5rzupmgaJpZM4KLKJy .

Omranic commented 7 years ago

Sure, all you've to do is to modify the following file: resources/divisions/ng.json. That's where all Nigerian divisions exists, good luck with that 👍

akeebismail commented 7 years ago

Ok I will get in back

ph-il commented 7 years ago

in .ph there is MNL that's empty. It must be Manila.

Omranic commented 2 years ago

I'm closing this due to inactivity, I'll be happy to consider PRs adding missing divisions, or updating existing ones. All PRs are welcome 😉