search

rinvex / countries

Rinvex Country is a simple and lightweight package for retrieving country details with flexibility. A whole bunch of data including name, demonym, capital, iso codes, dialling codes, geo data, currencies, flags, emoji, and other attributes for all 250 countries worldwide at your fingertips.
https://rinvex.com
MIT License
1.66k stars 208 forks source link

PHP 7 or broken exception?! #56

Closed joshbrw closed 5 years ago

joshbrw commented 7 years ago

The 2.0 tag is php 5.6 compatible but has a broken namespace, 3.0 is 7.0+ only?

Omranic commented 7 years ago

Yes, v3 requires PHP 7.0+ But what do you mean by broken namespace in v2? Could you clarify & mention how to re-produce your issue. We may be able to commit a fix to the old v2 branch!

joshbrw commented 7 years ago

Check the commits on my fork here; https://github.com/joshbrw/country/commits/php-5.6

I may just be able to PR that branch into the v2 branch, let me see.

joshbrw commented 7 years ago

@Omranic Could you please create a V2 branch at the current v2.0.0 tag's commit?

joshbrw commented 7 years ago

It's this commit that needs pulling in - https://github.com/joshbrw/country/commit/af4fe47d4877297e27ec7cda0e04722f43f608f0

Omranic commented 5 years ago

Outdated issue, shouldn't be an issue in recent releases! PHP 5.x is officially no longer supported, and thus we're supporting PHP v7+