search

rinvex / laravel-repositories

⚠️ [ABANDONED] Rinvex Repository is a simple, intuitive, and smart implementation of Active Repository with extremely flexible & granular caching system for Laravel, used to abstract the data layer, making applications more flexible to maintain.
https://rinvex.com
MIT License
666 stars 115 forks source link

Not working with Laravel 5.4? #136

Closed cewlbird closed 7 years ago

cewlbird commented 7 years ago

Hi,

first of all thank you for this greate package!

Will there be any Laravel 5.4 support? Because I saw in the commits that you reverted the 5.4 support.

There are errors when trying to create an entity with your package.

Type error: Argument 1 passed to Rinvex\Repository\Listeners\RepositoryEventListener::entityCreated() must implement interface Rinvex\Repository\Contracts\RepositoryContract, string given

Regards,

CewlBird

Omranic commented 7 years ago

Yes, Laravel 5.4 support will be available very soon on the dev-develop branch and then will make it to the next major release later on, but the 2.x branch will kept compatible with up to L5.3.

cewlbird commented 7 years ago

Awesome, glad to hear that. Again thank you for this great work, really looking forward for more awesome stuff!

rjsworking commented 7 years ago

@Omranic Hi. Do you have an ETA ?

rjsworking commented 7 years ago

Hi.

There's an issue with latest dev-develop branch. 

$repo->setCacheDriver('foobar');

Doesn't throw any error as 2.0.2 do.

Update I think there's a problem with cache. Tried file, memcached, redis but I don't see any cached data.

Omranic commented 7 years ago

This Midnight UTC 😬

Omranic commented 7 years ago

Fixed on dev-develop please composer update & post again if there's still any other issues. Sorry for the long wait 🙂 e2226399eb315f84f5ef3398c1ccdfec8540b56c

rjsworking commented 7 years ago

Thank you very much :)