rinvex / laravel-support

Rinvex common support helpers, contracts, and traits required by various Rinvex packages. Validator functionality, and basic controller included out-of-the-box.
https://rinvex.com
MIT License
73 stars 70 forks source link

Laravel 9 support #64

Closed Pilskalns closed 2 years ago

Pilskalns commented 2 years ago

Hi,

This package is dependent on rinvex/tmp-watson-validating ^6.0.0 which in turn depends on illuminate/validation ^8.0 thus breaking the dependency chain. To my understanding, the dependencies on validating package should be updated.

The full dependency chain: L9 > rinvex/laravel-addresses ^6.0 > rinvex/laravel-support ^6.0.0 > rinvex/tmp-watson-validating ^6.0.0 > illuminate/validation ^8.0.0

P.S. creating issue here since the tmp-watson-validating package does not have Issue Tracker enabled.

robbielove commented 2 years ago

We don't even need the tmp-watson-validating anymore - this fork was originally used because https://github.com/dwightwatson/validating didn't have L8 support.

It now has L9 support so it could just be switched to use that and problem solved? 🤷‍♂️

stephenjude commented 2 years ago

Yeah was trying to add L9 support because of the same issue. What's do you suggest @robbielove

Omranic commented 2 years ago

@Pilskalns @stephenjude thanks, L9 support coming this week 👍

@robbielove awesome, that's good news, will check that and switch it back then 🙌

stephenjude commented 2 years ago

Thanks @Omranic

Omranic commented 2 years ago

Laravel v9 is now supported in latest release v6.1.0, also all of our packages now supports Laravel v9.

Note when using this package with Laravel v9

This package requires felixkiss/uniquewith-validator dependency, which is not yet compatible with Laravel v9! However as a temporary workaround, add Laravel Shift's fork to the repositories property of your project root composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/uniquewith-validator.git"
        }
    ]
}
azenot-dev commented 1 year ago

Laravel v9 is now supported in latest release v6.1.0, also all of our packages now supports Laravel v9.

Note when using this package with Laravel v9

This package requires felixkiss/uniquewith-validator dependency, which is not yet compatible with Laravel v9! However as a temporary workaround, add Laravel Shift's fork to the repositories property of your project root composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/uniquewith-validator.git"
        }
    ]
}

I get this error GitHub API limit (0 calls/hr) is exhausted, could not fetch https://api.github.com/repos/laravel-shift/uniquewith-validator/commits/ad94e9b14bca5e7afd9a578c023fe3937d6bcdaa. Create a GitHub OAuth token to go over the API rate limit. You can also wait until ? for the rate limit to reset.

Omranic commented 1 year ago

@azenot-dev https://getcomposer.org/doc/articles/troubleshooting.md#api-rate-limit-and-oauth-tokens

Omranic commented 1 year ago

Update: we dropped the felixkiss/uniquewith-validator dependency from this package 🙂 https://github.com/rinvex/laravel-support/commit/2bf69b8dcbf6f18ecd97c2c7b43ae441d58765cd

robbielove commented 1 year ago

Thanks for that