Closed Pilskalns closed 2 years ago
We don't even need the tmp-watson-validating
anymore - this fork was originally used because https://github.com/dwightwatson/validating didn't have L8 support.
It now has L9 support so it could just be switched to use that and problem solved? 🤷♂️
Yeah was trying to add L9 support because of the same issue. What's do you suggest @robbielove
@Pilskalns @stephenjude thanks, L9 support coming this week 👍
@robbielove awesome, that's good news, will check that and switch it back then 🙌
Thanks @Omranic
Laravel v9 is now supported in latest release v6.1.0, also all of our packages now supports Laravel v9.
This package requires felixkiss/uniquewith-validator
dependency, which is not yet compatible with Laravel v9! However as a temporary workaround, add Laravel Shift's fork to the repositories
property of your project root composer.json
:
{
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/uniquewith-validator.git"
}
]
}
Laravel v9 is now supported in latest release v6.1.0, also all of our packages now supports Laravel v9.
Note when using this package with Laravel v9
This package requires
felixkiss/uniquewith-validator
dependency, which is not yet compatible with Laravel v9! However as a temporary workaround, add Laravel Shift's fork to therepositories
property of your project rootcomposer.json
:{ "repositories": [ { "type": "vcs", "url": "https://github.com/laravel-shift/uniquewith-validator.git" } ] }
I get this error GitHub API limit (0 calls/hr) is exhausted, could not fetch https://api.github.com/repos/laravel-shift/uniquewith-validator/commits/ad94e9b14bca5e7afd9a578c023fe3937d6bcdaa. Create a GitHub OAuth token to go over the API rate limit. You can also wait until ? for the rate limit to reset.
Update: we dropped the felixkiss/uniquewith-validator
dependency from this package 🙂 https://github.com/rinvex/laravel-support/commit/2bf69b8dcbf6f18ecd97c2c7b43ae441d58765cd
Thanks for that
Hi,
This package is dependent on
rinvex/tmp-watson-validating ^6.0.0
which in turn depends onilluminate/validation ^8.0
thus breaking the dependency chain. To my understanding, the dependencies on validating package should be updated.The full dependency chain:
L9
>rinvex/laravel-addresses ^6.0
>rinvex/laravel-support ^6.0.0
>rinvex/tmp-watson-validating ^6.0.0
>illuminate/validation ^8.0.0
P.S. creating issue here since the
tmp-watson-validating
package does not have Issue Tracker enabled.