search

rinvex / laravel-support

Rinvex common support helpers, contracts, and traits required by various Rinvex packages. Validator functionality, and basic controller included out-of-the-box.
https://rinvex.com
MIT License
73 stars 70 forks source link

Update composer.json #66

Closed mattvb91 closed 1 year ago

mattvb91 commented 1 year ago

replace "felixkiss/uniquewith-validator": "dev-l9-compatibility" due to non existant branch with read only repository. The original repo has been abandoned.

Please allow CI runs to make sure this still works properly. Only changes on this is the laravel shift commit + package name + tag

See all changes here: https://github.com/mattvb91/uniquewith-validator/compare/3.4.2...3.4.3

mattvb91 commented 1 year ago

@Omranic sorry I didnt realize there was no CI on this repo, can you give this a look over to see if you can spot any issues im not sure how to best test this.

The original repository doesnt actually have the dev-l9-compatibility branch so you cant pull this laravel-support repo since 6.1.0

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 5db1f557 and detected 0 issues on this pull request.

View more on Code Climate.

Omranic commented 1 year ago

Thank you @mattvb91, however the repo you provided 'https://github.com/mattvb91/uniquewith-validator/compare/3.4.2...3.4.3' is abandoned!

Despite that, I don't see a need for any change as the current instructions still work correctly. If you followed the instructions, you won't be pulling the dev-l9-compatibility from the original repo, instead it's gonna be pulled from here https://github.com/laravel-shift/uniquewith-validator

mattvb91 commented 1 year ago

@Omranic of course its abandoned... so is the original. The difference here is that this version works. The current dev-l9-compatibility DOES NOT WORK if your pulling in various CI tools due to the overrides requiring custom composer aut tokens.

Omranic commented 1 year ago

I understand, thank you for your input. I’d still rather stick with the existing shift fork at the time being until there’s a more reliable solution. I agree it’s not perfect, but it is what it is. I hope this package could be maintained pr replaced one day.

Omranic commented 1 year ago

FYI, we dropped the felixkiss/uniquewith-validator dependency from this package 🙂 https://github.com/rinvex/laravel-support/commit/2bf69b8dcbf6f18ecd97c2c7b43ae441d58765cd