search

riobard / go-acme

Automated Certificate Management Environment (ACME) client in Go using just standard library
34 stars 3 forks source link

Consider setting a User Agent #1

Open cpu opened 7 years ago

cpu commented 7 years ago

Hi there, neat client!

Whenever I find a new ACME client I check the source to see if they're setting a user agent. This is really useful from a server operator perspective because it helps us identify misbehaving clients & understand the ecosystem from our request logs.

Section 6.1 of the ACME spec goes as far as to say clients SHOULD set a UA:

ACME clients SHOULD send a User-Agent header in accordance with [RFC7231], including the name and version of the ACME software in addition to the name and version of the underlying HTTP client software.

Would you consider adding a UA to go-acme? Thanks!

riobard commented 7 years ago

Hmm, weird I missed notification for this issue.

Just checked and it seemed to be quite some work to add custom header. Probably have to wait till next refactor to add UA. Besides, the tool is not widely used so far so the impact should be minimal :)

cpu commented 7 years ago

@riobard That's fair :-) thanks for considering!

riobard commented 7 years ago

I'll leave this issue open till I got some time to rewrite the stuff. Probably when the wildcard domain support kicks in next year (which requires dns-01 I think?). Kudos for the great work at LetsEncrypt.org! 👍