Debugging the LightCurve Class and updates at Occultation log - Githubissues

riogroup / SORA

MIT License

15 stars 12 forks source link

Debugging the LightCurve Class and updates at Occultation log #24

Closed Bmorgado19 closed 4 years ago

Bmorgado19 commented 4 years ago

Fixed issues on LightCurve Class

Issue #9: Now the LightCurve will save the last complete model considering the fitted immersion and emersion times, even when they were fitted separately.
Issue #19: LightCurve.set_flux() now reads correctly files with three columns, where the 3rd is the flux uncertainty.
Issue #23: An RaiseError was added when the exptime is negative or zero.

Added parameters at print(Occultation) and Occultation.to_log() as demanded on Issue #17.

S-G-T angle;
M-G-T angle;
Polar radius;
Equivalent radius.

After the pull request's revision and its approval, I will include the related modifications at the Releases.rst.

altairgomes commented 4 years ago

I've made some comments relative to PEP8 recommendations. It does not prevent merging. We can check it again and fix when we release v0.2.