search

riogroup / SORA

MIT License
15 stars 12 forks source link

Lambda vs Lambida in Lightcurve #36

Closed gugabrossi closed 4 years ago

gugabrossi commented 4 years ago

In lightcurve.py there are two definitions for variables. It is better to use just one "lambda" (no i ).

Bmorgado19 commented 4 years ago

That mistranslation was clearly a typo. I will correct that for the next version.

altairgomes commented 4 years ago

The problem with the name "lambda" is that it exists a python native function with this name that would be overwritten, https://www.w3schools.com/python/python_lambda.asp. It is not a problem if the lambda function is not used. But maybe it would be better to give a more straightforward name to the variable instead of "lambda".

Bmorgado19 commented 4 years ago

I agree that we should use another name for this variable. Now we have lambda and delta_lambda, meaning the center bandpass of the detector used in observation and its width. I suggest that this variable should be deprecated and bandpass (and delta_bandpass) should be used instead.