New Feature VizierCatalogue

riogroup / SORA

MIT License

15 stars 12 forks source link

New Feature VizierCatalogue #71

Closed altairgomes closed 2 years ago

altairgomes commented 2 years ago

This pull request adds a new class called VizierCatalogue in the catalogue sub module. With it, the user can define the necessary keywords to allow SORA to download information from any catalogue available on Vizier.

The new feature was implemented in the prediction() function and the Star() class. Thus the user can make predictions or process an occultation by using the information from other catalogues than the default Gaia.

A jupyter notebook was added to the "examples" page showing how the new feature is intended to be used.

Bmorgado19 commented 2 years ago

Thanks for this Pull Request. I have four comments, mainly about the internal documentation of the new features:

You should include more information on the VizierCatalogue docstring;
Within the prediction() functions, please modify the docstring stating that the catalogue argument can be a VizierCatalogue object;
You should include a better __string__ within the VizierCatalogue Class;
Using the VizierCatalogue within the Star Class, I got a warning, and it appears that you are trying to add the magnitudes of the stars two times;

altairgomes commented 2 years ago

Using the VizierCatalogue within the Star Class, I got a warning, and it appears that you are trying to add the magnitudes of the stars two times;

That's because you probably are adding it two times. When you define the star, it downloads the magnitudes for all bands. Then, if you put nomad=True it will download the magnitudes for the NOMAD bands. If any band is in both catalogs, it will be replaced by NOMAD.