TimothyMakkison
commented
1 year ago Looks like the mapper recursively calls itself when UseDeepCloning is enabled. Object-> Object will run and cause a stackoverflow, Object? -> Object? will crash my ide.
My minimal reproducible example:
Program
var copy = MyMapper.Clone("Hello World");
Console.WriteLine(JsonSerializer.Serialize(copy, new JsonSerializerOptions { WriteIndented = true }));
[Mapper(UseDeepCloning = true )]
public static partial class MyMapper
{
public static partial object Clone(object f);
// uncommenting this will crash my ide
//public static partial object? Clone(object? f);
//uncomment this and it fixes it
//private static object ObjectToObject(object t) => t;
}MyMapper.g.cs
#nullable enable
public static partial class MyMapper
{
public static partial object Clone(object f)
{
return (object)Clone(f);
}
}Hacky fix
Currently SpecialTypeMappingBuilder will attempt to map the source to itself when target is an object. Unfortunately when source is also an object a recursive call can be created. By adding an additional branch to SpecialTypeMappingBuilder we can prevent this from happening.
This probably isn't a good solution as a shallow clone will be used instead of deep clone. Perhaps it would be better to avoid creating a mapping and raise a warning instead.
SpecialTypeMappingBuilder
return ctx.Target.SpecialType switch
{
SpecialType.System_Object when ctx.MapperConfiguration.UseDeepCloning && ctx.Source.SpecialType == SpecialType.System_Object
=> new DirectAssignmentMapping(ctx.Source),MyMapper.g.cs
public static partial class MyMapper
{
public static partial object Clone(object f)
{
return f;
// return f == null ? default : f; // for object? -> object?
}
}
latonz
github-actions[bot]
DumboJetEngine
Describe the bug
Using this example code, will make Visual Studio hang and crash as soon as you add the
Object? Itemproperty, or[Mapper]attribute (I assume it is the source generator in some infinite loop or something):The mapper will probably not know what to do with a reference to type Object -- but it should not crash visual studio. Workaround is adding
private object? ObjectToObject(object? t) => t;to the mapper so the generator knows what to do.Expected behavior Probably skipping the
Object? Itemproperty? Or just setting the reference as I do in my usecase.Environment (please complete the following information):