search

riolubruh / YABDP4Nitro

Yet Another BetterDiscord Plugin for Nitro features. Unlock screensharing modes, use cross-server and gif emotes and much more!
Other
803 stars 140 forks source link

[Bug Report] File Upload with Emoji causes bypass to fail #206

Closed StShAzzy closed 5 months ago

StShAzzy commented 6 months ago

hello, one more time if you embed a image in a message you're sending and insert a emoji on the message the bypass fails completely the image is send and the emoji is sent as regular text

if for whatever reason it's not possible to send both on the same message, could you add a warning pop-up about it?

riolubruh commented 6 months ago

I believe the reason for this is because when sending a file the client uses the uploadFiles function instead of the sendMessage function, and none of the emoji bypasses patch the uploadFiles function.

riolubruh commented 6 months ago

@StShAzzy Let me know your opinion on this: should the emoji (assuming upload bypass is used) be in a separate message or attached to the same message as the file? Additionally, if it would be attached to the same message, how do you think it should be handled if the maximum 10 attachments is reached?

StShAzzy commented 6 months ago

yeah, that's a problem, the maximum attachment limit would be pretty annoying to deal with so... i guess attaching the emoji and sending a new message with the bypass emoji would be enough, althrough, you could still append the emoji to the current message depending on how many files the user is sending

StShAzzy commented 6 months ago

also, if you ever get bored of waiting for me to answer, you can just send the message on discord, we still share a single server (T.C.R.F)