search

riolubruh / YABDP4Nitro

Yet Another BetterDiscord Plugin for Nitro features. Unlock screensharing modes, use cross-server and gif emotes and much more!
Other
778 stars 141 forks source link

PSA: Vanilla/unmodded Screen Share Viewer crashes when viewing a stream with a custom resolution or FPS #213

Closed riolubruh closed 1 week ago

riolubruh commented 3 months ago

Discord has recently attempted to limit resolutions and FPSes to intended values using the following functions: Discord_GhfRDN84DI YABDP4Nitro has patched these functions to prevent the error throw, however ANY clients that have not patched these functions will crash when viewing or starting a stream with unintended values. Discord will hopefully/likely revert this change, as if the client throws an error in this fashion, it crashes the whole client. Because Discord will likely revert this change, I will not fix it for some time. In the meantime, everyone have fun crashing unsuspecting users!

Edit: I have reported the issue to Discord.

misterpyrrhuloxia commented 3 months ago

Edit: I have reported the issue to Discord.

@riolubruh, did you report it without telling them what's causing the crash? Like, did you tell them it's because of a BetterDiscord plugin?

riolubruh commented 3 months ago

@riolubruh, did you report it without telling them what's causing the crash? Like, did you tell them it's because of a BetterDiscord plugin?

In short, I told them which functions were causing it and how a user with a client mod could exploit these functions to cause a crash to any user who they can get to just watch a video stream. I did not mention BetterDiscord or any client mods or plugins by name. Also, they still have not replied to the report yet.

riolubruh commented 2 months ago

Since Discord has not fixed this in such a long time, custom screen share resolution and fps will likely be removed soon.

themegaxandy commented 1 month ago

Since Discord has not fixed this in such a long time, custom screen share resolution and fps will likely be removed soon.

Please don't remove this feature. I downloaded this plugin just for this reason. I'm not using it to crash users' clients, but because Discord just removed the option to stream at 480p and I have shitty internet speeds.

Instead of removing it completely, you could allow only the options available in the code, since Discord's native options are too limited.

riolubruh commented 1 week ago

It seems Discord has just fixed the crashing issue in one of the recent updates, and custom FPS and resolution still work! If anyone is still experiencing the issue, please get in contact!