rionshocker / pe

0 stars 0 forks source link

Able to edit a contact to have the same phone number as what has already been keyed in #1

Open rionshocker opened 1 year ago

rionshocker commented 1 year ago

Screenshot 2023-11-17 at 4.14.05 PM.png

There's the ability to edit a contact to have the same phone number as another TA in the app.

Steps to replicate:

  1. edit 1 p/99272758

99272758 is stated to be the phone number of the second person in the list.

Might be a problem in which 2 people usually do not have the same phone number, especially in the current context given.

soc-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to add TAs with different names, yet the same for other attributes.

Screenshot 2023-11-17 at 4.35.19 PM.png

From the above screenshot, index 13 and 14 have the same fields, but different names. Given that their phone numbers / telegram handle / email addresses are the same, it would make sense that this should not be allowed, as TAs should not just have different names, they should by right have different phone numbers, telegram handles and email addresses as well.


[original: nus-cs2103-AY2324S1/pe-interim#4711] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The same issue of how we check duplicates. We have to properly define how we handle duplicates.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]