rionshocker / pe

0 stars 0 forks source link

Extra whitespace case when adding a contact. #3

Open rionshocker opened 1 year ago

rionshocker commented 1 year ago

When keying in a new contact, extra whitespaces are still taken as the input, resulting in there being 2 contacts possibly having the same name despite the names being the same if the whitespace was trimmed.

Steps to replicate:

  1. add n/Alex  Yeoh p/99272758 e/alexyeoh@example.com tele/@alexyeoh t/fulltime c/cs1231s

Screenshot 2023-11-17 at 4.32.08 PM.png

Screenshot 2023-11-17 at 4.32.26 PM.png

nus-se-script commented 1 year ago

Team's Response

Similar issue where we should have considered them as duplicate names.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names are not case-insensitive

Screenshot 2023-11-17 at 4.26.13 PM.png

I am able to add John Doe, john Doe and other variations with different capitalisations, as they are regarded as separate entities with different names. However, it would be more user friendly if such fields are case-insensitive, as there may be a rare occasion whereby the user accidentally adds someone who was already in the system, but with different "casing" .


[original: nus-cs2103-AY2324S1/pe-interim#4338] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The issue was about not validating the whitespaces between names as users can potentially accidentally press the spacebar twice when keying in names. However, it was marked as a duplicate of an issue that talks about the names being case sensitive instead, which is a different issue altogether.


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]