search

rionshocker / pe

0 stars 0 forks source link

Inaccuracy in `Finding TA feature` sequence diagram in DG #8

Open rionshocker opened 1 year ago

rionshocker commented 1 year ago

As can be seen in the screenshot below, f:findCommand gets returned twice, but it should have been returned from FindCommandParser to AddressBookParser instead.

Screenshot 2023-11-17 at 5.27.09 PM.png

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Lifeline of FindCommandParser does not terminate at X

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

the lifeline of the FindCommandParser does not terminate at the X.

A warning should be attached to the image similar to previous examples in the DG

[original: nus-cs2103-AY2324S1/pe-interim#1433] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is a PlantUML constraint which is acknowledged in CS2103T.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The duplicate issue is talking about the lifeline, however, I'm referring to the second return arrow being wrongly placed for findCommand.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Though having the possibility of just being a cosmetic bug, it is inaccurate to show the return arrow in this manner.