riot / observable

Simple script to listen and dispatch events
MIT License
66 stars 13 forks source link

Moving observable.js from RIot #1

Closed cognitom closed 9 years ago

cognitom commented 9 years ago

I'm trying to extract observable.js to the new repo with its git history. https://github.com/cognitom/observable/blame/dev/observable.js

But the history before the commit has disappeared. Original one is this. https://github.com/riot/riot/blame/master/lib/browser/observable.js

What I've tried are these commands:

$ git clone riotjs observable
$ cd observable/
$ git filter-branch --subdirectory-filter lib/browser/ HEAD
$ git filter-branch --index-filter 'git rm router.js' HEAD
# and remove others, too
$ git tag -d `git tag | grep -E '.'`

I'm new about filter-branch. Is there any idea?

GianlucaGuarini commented 9 years ago

I will be on this once riot 2.2.0 will be released. I would not overcomplicate the workflow. We can just move the observable code in here and make a npm module riot-observable. You should pay attention that this module should be written with an UMD export

cognitom commented 9 years ago

Sure. UMD and mabe smash, too.

GianlucaGuarini commented 9 years ago

Probably the next release will use something like babeljs and a better build (webpack). We need to discuss about it. Now I am focused just on the next release

cognitom commented 9 years ago

OK, pls focus on the next release :v:

tipiirai commented 9 years ago

Definitely curious about babeljs and the benefits for Riot.

GianlucaGuarini commented 9 years ago

This repo is ready to be published on npm I am just waiting that the riot-observable domain on npm will be available again https://github.com/callumlocke/riot-observable/issues/1

cognitom commented 9 years ago

Cool! Thanks @GianlucaGuarini

GianlucaGuarini commented 9 years ago

riot-observable is finally on npm https://www.npmjs.com/package/riot-observable

cognitom commented 9 years ago

:tada:

GianlucaGuarini commented 9 years ago

the current riot in the dev branch loads this submodule without any problem. Closing this issue