search

riot / route

Simple isomorphic router
MIT License
212 stars 40 forks source link

make start wait for readyState interactive instead complete to avoid … #89

Closed msveden closed 7 years ago

msveden commented 7 years ago

…slow loading resources from blocking the app

Third party scripts, hosted somewhere else, block the router and hence the whole app until they are loaded.

The change is in src/index.js, the other changes are made by "npm run build".

GianlucaGuarini commented 7 years ago

@msveden could you please avoid changes in the generated files and change only the source code?

msveden commented 7 years ago

Sorry I didn't know you didn't keep dist up-to-date with the source.

I want to be able to refer to my commit in my package.json and use "npm install" and have it up and running just like if it was the official package.

Is there a way I can do this without changing dist and without modifying the build process for my product?

I can of course just put the change in a different branch. Is that better?

GianlucaGuarini commented 7 years ago

@msveden I would make a new clean pull request committing only the source files you have changed and adding readyState === 'interactive' || readyState === 'complete' as well

msveden commented 7 years ago

Closing this request as it has been replaced by another.