search

riot / syntax-highlight

Riot tags syntax rules
MIT License
14 stars 1 forks source link

Submit riot .tag syntax to linguist #5

Open GianlucaGuarini opened 7 years ago

GianlucaGuarini commented 7 years ago

Follow up of: https://github.com/riot/riot/issues/1953

crisward commented 7 years ago

Working on this now. The colour used is too close to others, so I may have to change it a little.

crisward commented 7 years ago

I've created a pull request. Had to use the colour #A71E49 which is not ideal, but there was an overlap with Objective-J and other 'red' languages.

crisward commented 7 years ago

https://github.com/github/linguist/pull/3720

GianlucaGuarini commented 7 years ago

@crisward thanks for your pull request but regarding the color I would like to keep #fc0e49 unless linguist requires a different color by specs. Please fix also the missing license data issue as well. Good job

crisward commented 7 years ago

Yes, I'm sorry to say the spec prevent choosing that color. I tried changing it a little at a time, but couldn't get anything to pass the tests that are even close to riot's color.

I'll take a look at the licence data.

GianlucaGuarini commented 7 years ago

@crisward I couldn't find anything about colors specs here

crisward commented 7 years ago

The colors are set here - https://github.com/crisward/linguist/blob/master/lib/linguist/languages.yml#L3759

When the test are run it checks how distinct they are. If they're not different enough from existing colors the tests fail and can't be merged.

I've added another LICENCE file to the language repository, but not sure how to get the tests to run again without making a random commit.

GianlucaGuarini commented 7 years ago

your pull request should be automatically updated when you push against master.. regarding the color decision maybe it will be worth pinging @JLehtinen