search

riotkit-org / docker-taiga

Production-ready docker container for Taiga https://taiga.io
https://quay.io/repository/riotkit/taiga?tab=tags
GNU General Public License v3.0
55 stars 8 forks source link

#8 enable CI automation to automatically build all recent versions of Taiga + generate README.md from template that includes env variables from Dockerfile #9

Closed blackandred closed 5 years ago

blackandred commented 5 years ago

I canceled the build on travis for pull request. As the builds are pushing to registry it's dangerous to grant pull requests to be built on travis. The builds should be triggered only from master.

There is a build that already pushed recent version of Taiga into the quay.io: https://travis-ci.org/riotkit-org/docker-taiga/builds/578044122

blackandred commented 5 years ago

taiga-quay

blackandred commented 5 years ago

Could anybody do a code review? @zicklag or @Leopere?

Leopere commented 5 years ago

I can’t test anything until the earliest about 16 hours from now but likely better chances 32 from now.

blackandred commented 5 years ago

I can’t test anything until the earliest about 16 hours from now but likely better chances 32 from now. … On Wed, Aug 28, 2019 at 5:14 PM Andrew Johnson @.***> wrote: Could anybody do a code review? @zicklag https://github.com/zicklag or @Leopere https://github.com/Leopere? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9?email_source=notifications&email_token=AAIE2VXIHQMWMMA3CGHEEVTQG3TCDA5CNFSM4IQ33AMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MPWJQ#issuecomment-525925158>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIE2VVNFOYFLZ5MMRT5R43QG3TCDANCNFSM4IQ33AMA .

Sure :smile: I have also a lot of this to do in the mean time, so take your time.

zicklag commented 5 years ago

I didn't test it, but I didn't notice anything outstandingly wrong in a quick code review.

blackandred commented 5 years ago

I deployed the recent version built with this code. It seems that its working fine on my prod instance.

On Thu, Aug 29, 2019 at 10:06 PM Zicklag notifications@github.com wrote:

I didn't test it, but I didn't notice anything outstandingly wrong in a quick code review.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/riotkit-org/docker-taiga/pull/9?email_source=notifications&email_token=AFOAJBXX74MUVO245N72KO3QHAT5XA5CNFSM4IQ33AMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5PVGGI#issuecomment-526340889, or mute the thread https://github.com/notifications/unsubscribe-auth/AFOAJBW2TIVV4APC76FXXTTQHAT5XANCNFSM4IQ33AMA .

blackandred commented 5 years ago

Ok, I will wait till Tuesday, then I will merge :smiley:

Leopere commented 5 years ago

Looks reasonable to me.

On Fri, Aug 30, 2019 at 1:30 PM Andrew Johnson notifications@github.com wrote:

Ok, I will wait till Tuesday, then I will merge 😃

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/riotkit-org/docker-taiga/pull/9?email_source=notifications&email_token=AAIE2VUFOIYWUBBWXNSKWBLQHFKMPA5CNFSM4IQ33AMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SJC2I#issuecomment-526684521, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIE2VS42YN6UO3OAR7GHJDQHFKMPANCNFSM4IQ33AMA .

blackandred commented 5 years ago

This branch contains fix for #11, so I will merge it faster. I will apply code review fixes if there will be ones within a new PR if you report anything.