search

ripaclub / zf2-sphinxsearch-tool

An utility that provides a set of tools to create and handle Sphinx Search configs and sources
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Externalize writer in another library #40

Open leodido opened 9 years ago

leodido commented 9 years ago

Externalize writer architecture and classes.

Then require this library and extend class to add

if (!isset($doc['id'])) {
    throw new NotValidDocumentException('Document array must have an element with "id" key');
}

where it is needed.

leogr commented 9 years ago

I don't think that externalizing the writer is an improvement. The writer is very specific and it could be used as standalone component already (just using zf2-sphinxsearch-tool as depedency).