riparias / gbif-alert

GBIF Alert is a GBIF occurrence based alert system.
https://gbif-alert-demo.thebinaryforest.net/
MIT License
8 stars 2 forks source link

Automatically change current website language after profile update #257

Closed niconoe closed 1 year ago

niconoe commented 1 year ago

@damianooldoni noticed that if a user change its preferred language in its profile, it has no effect on the selected language of the website (only for emails).

While I think it's important to let users the freedom change language at any time using the selector in the navbar, it might be more user-friendly to automatically change it just when the user save/update its profile.

damianooldoni commented 1 year ago

Hi Nico! Actually I think the situation at the moment is very user friendly: the language selector in the navbar is great. I think the problem here is the fact that the language field in My Profile is confusing. I got confused just after a month of holidays 😄

The language of the alert notifications is a property of the alert, exactly as the notification frequency.. I think we should move this field in the Alert page. It can be perfectly put below the frequency notification field and calling it "Alert notifications language". They fit nicely. What do you think? This means the language could change from an alert to another, even if this is unlikely to happen of course. Is the engine flexible enough to support this so that you have not to work on it too much? Otherwise, we have a very easy alternative: just replace "Language" with "Language of alert email notifications" in the Profile panel 😄

niconoe commented 1 year ago

Hey @damianooldoni, if you're okay with this I think I will rather update the text in the profile form. There would be no technical problem to move the language to the Alert (rather than the user), but I think it doesn't make much sense:

Therefore, I think the language should stay a user property rather than the alert property.

damianooldoni commented 1 year ago

Great! It makes sense to me.

niconoe commented 1 year ago

I improved things as discussed:

damianooldoni commented 1 year ago

I don't see changes on RIPARIAS production website. Maybe will change in a few minutes or tomorrow?

niconoe commented 1 year ago

I just had to revert the second change ("The current language is updated on profile save") because it's hard to make this work reliably and I don't want to spend too much time at this (late) stage for a minor issue.

The clearer message is kept.

Things are not visible yet on production, because I didn't create a release with recent changes yet, I'll do that ASAP.